This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
General: Local overrides for environment variables #3045
Merged
+179
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Give ability to define white list of environment variables that can be changed per machine.
Description
In
system_settings/general
was added new keylocal_env_white_list
where is possible to define environment variable keys that can be changed per machine. Values of the environment variable keys can be set in Local settings UI. Values are applied on application launch and only if launch environments contain the keys.Additional info
These environment variable changes are not applied on OpenPype launch but only on application launch.
Questions
system_settings/general/local_env_white_list
, it could be maybe added under applications as it's related to them?Documentation
TODO modify documentation based on answer of question 1
Testing notes:
system_settings/general/local_env_white_list
(e.g."TEST"
)"TEST": "OriginValue"
)"MyValue"
)For more complex test also add tool and use the environment key in other key as value.
5. Choose one tool and add there different key using the key from step 1 (e.g.: "SUBKEY_TEST": "This is {TEST}"
) 6. Make sure the tool is added to asset on which you're testing 7. Launch the application and check value of the key from step 5 (
"SUBKEY_TEST"should have
"MyValue"`)When key is removed from
system_settings/general/local_env_white_list
it should not be overriden even if is still available in local settings.Screenshots